Nowarn extension matching nonpublic member #21825
Merged
+30
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Possibly, a |
smarter
reviewed
Oct 22, 2024
Comment on lines
1172
to
1173
| val memberIsPublic = (member.symbol.flags & AccessFlags).isEmpty && !member.symbol.privateWithin.exists | ||
| memberIsPublic && { |
There was a problem hiding this comment.
This could be member.symbol.isPublic but we can also be more precise and check for accessibility (untested):
Suggested change
| val memberIsPublic = (member.symbol.flags & AccessFlags).isEmpty && !member.symbol.privateWithin.exists | |
| memberIsPublic && { | |
| val memberIsAccessible = member.symbol.isAccessibleFrom(target) | |
| memberIsAccessible && { |
There was a problem hiding this comment.
I'll take another look during daylight, as my first swing was during interrupted sleep. I think the use case is an arbitrary use site, so that is the reason to require isPublic. I'll reconsider after coffee.
WojciechMazur
added
the
backport:nominated
sjrd
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21816
Consider only public members when checking if an extension method actually extends.
A use site lint would be more thorough, when an extension is in scope but unused because of a visible matching member.